Run spyre checks only on RHEL and Fedora#35
Open
sahithiRavindranath wants to merge 1 commit intolinux-ras:spyrefrom
Open
Run spyre checks only on RHEL and Fedora#35sahithiRavindranath wants to merge 1 commit intolinux-ras:spyrefrom
sahithiRavindranath wants to merge 1 commit intolinux-ras:spyrefrom
Conversation
sahithiRavindranath
force-pushed
the
spyre1
branch
3 times, most recently
from
dcd3da1 to
5ca1d2b
Compare
sahithiRavindranath
force-pushed
the
spyre1
branch
from
81345a7 to
5ca1d2b
Compare
| return perm_check | ||
|
|
||
| def check_sos_package(self): | ||
| """sos package""" |
Contributor
There was a problem hiding this comment.
Why sos package and sos config check are still part of Sypre class. sos checks are RHEL and Fedora specific?
If a new plugin class is defined for SLES then those will come there also right?
Author
There was a problem hiding this comment.
yes created a new class SpyreSoS for sos checks , If SLES comes in we can exclude sos checks now.
sahithiRavindranath
force-pushed
the
spyre1
branch
from
5ca1d2b to
b55d339
Compare
All Spyre checks are now gated by the RHEL and Fedora schemes Signed-off-by: Sahithi Ravindranath <Sahithi.Ravindranath@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Spyre checks are now gated by the RHEL and Fedora schemes